Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for completion in Oh My Zsh #881

Merged
merged 6 commits into from
Mar 16, 2021

Conversation

Stigjb
Copy link
Contributor

@Stigjb Stigjb commented Sep 19, 2019

Fixes exercism/exercism#5029

Also cf. #865

Changed oh-my-zsh to Oh My Zsh to match the style in the official repo

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, so sorry I missed the original ping and made you wait for a month for feedback!

I have one question as the copy command looks surprising to me, but otherwise this is ready to go.

@Stigjb
Copy link
Contributor Author

Stigjb commented Jan 14, 2020

Ping 😄

@haus
Copy link

haus commented Jan 26, 2020

Might be worth adding a note about clearing the completion cache (https://github.com/ohmyzsh/ohmyzsh/wiki/FAQ#i-have-enabled-a-completion-plugin-but-the-completion-doesnt-work). This had me tripped up for quite a while before I got it working.

@NoZiL
Copy link

NoZiL commented Oct 14, 2020

This works well and should be merged 👍

@kotp
Copy link
Member

kotp commented Oct 15, 2020

Approving, but @haus or @NoZiL could add note on clearing the cache??

@NoZiL
Copy link

NoZiL commented Oct 15, 2020

I didn't encounter any cache problems with a clean install, and there seems to be a note stating that the completion is now checking the plugin list on their wiki
I can add a note about updating OhMyZsh to the latest version that should fix any completion problem.

@Stigjb Stigjb force-pushed the oh-my-zsh-instructions branch from d505c47 to 48fe515 Compare January 19, 2021 09:21
Base automatically changed from master to main January 28, 2021 22:32
@allentiak
Copy link

@Stigjb Could you please help me understand why does one of the checks fail?

@Stigjb
Copy link
Contributor Author

Stigjb commented Mar 10, 2021

@allentiak I do not know why it failed, but it succeeded after updating the PR with the main branch

@allentiak
Copy link

allentiak commented Mar 15, 2021

@kotp @kytrinyx What else is needed for this to be merged?

@kotp
Copy link
Member

kotp commented Mar 16, 2021

I would merge, but I don't have the appropriate rights.

Give it a day or so, we should hear something back.

@iHiD iHiD merged commit 7cc4e6c into exercism:main Mar 16, 2021
@allentiak
Copy link

Thanks!

@Stigjb Stigjb deleted the oh-my-zsh-instructions branch March 17, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with completion script on Mac OS + Oh My Zsh
7 participants